[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311988: clang-format: [JS] simplify template string wrapping. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D37142 Files: cfe/trunk/lib/Format/ContinuationIndenter.cpp cfe/tr

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1139 + + // On lines containing template strings, propagate NoLineBreak even for dict + // and array literals. This is to force wrapping an initial function call if mprobst wrote: >

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst updated this revision to Diff 113036. mprobst added a comment. - drop function name wrapping hack https://reviews.llvm.org/D37142 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ==

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1139 + + // On lines containing template strings, propagate NoLineBreak even for dict + // and array literals. This is to force wrapping an initial function call if djasper wrote: >

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1139 + + // On lines containing template strings, propagate NoLineBreak even for dict + // and array literals. This is to force wrapping an initial function call if mprobst wrote: >

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1139 + + // On lines containing template strings, propagate NoLineBreak even for dict + // and array literals. This is to force wrapping an initial function call if djasper wrote: >

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1139 + + // On lines containing template strings, propagate NoLineBreak even for dict + // and array literals. This is to force wrapping an initial function call if This is not the r

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst updated this revision to Diff 112858. mprobst added a comment. - clang-format: [JS] wrap calls w/ literals in template strings. https://reviews.llvm.org/D37142 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Yay for *removing* complexity for a change :). Let me know how it goes in practice. https://reviews.llvm.org/D37142 ___ cfe-commits mailing lis

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst created this revision. Herald added a subscriber: klimek. Previously, clang-format would try to wrap template string substitutions by indenting relative to the openening `${`. This helped with indenting structured strings, such as strings containing HTML, as the substitutions would be alig