[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-09-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312904: [clang-format] Fixed one-line if statement (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D37140?vs=113979&id=114558#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-09-08 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee added a comment. Yes, would be great :) Thank you! https://reviews.llvm.org/D37140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-09-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Great! Would you like me to commit this for you? https://reviews.llvm.org/D37140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-09-06 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:286 } +if (TheLine->Last->is(tok::l_brace) && +TheLine->First != TheLine->Last && PriMee wrote: > krasimir wrote: > > No tests fail if this `if` statement gets remove

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-09-06 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee updated this revision to Diff 113979. PriMee added a comment. Diff file again updated. Created against the newest commit. https://reviews.llvm.org/D37140 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-08-31 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee added a comment. Sorry for wrong formatting before. Some inline comments added. Comment at: lib/Format/UnwrappedLineFormatter.cpp:286 } +if (TheLine->Last->is(tok::l_brace) && +TheLine->First != TheLine->Last && krasimir wrote: > No test

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-08-31 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee updated this revision to Diff 113379. PriMee added a comment. Diff file updated. Some tests added. Some new bugs fixed as well :) https://reviews.llvm.org/D37140 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-08-30 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:286 } +if (TheLine->Last->is(tok::l_brace) && +TheLine->First != TheLine->Last && No tests fail if this `if` statement gets removed. Please either remove it or add

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-08-29 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee updated this revision to Diff 113074. PriMee added a comment. Unit tests added. https://reviews.llvm.org/D37140 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D37140: [clang-format] Fixed one-line if statement

2017-08-25 Thread Pawel Maciocha via Phabricator via cfe-commits
PriMee created this revision. Herald added a subscriber: klimek. **Short overview:** Fixed bug: https://bugs.llvm.org/show_bug.cgi?id=34001 Clang-format bug resulting in a strange behavior of control statements short blocks. Different flags combinations do not guarantee expected result. Turned