rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D37122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311905: Change Diagnostic Category size error from runtime
to compiletime (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D37122?vs=112916&id=112931#toc
Repository:
rL LLV
erichkeane updated this revision to Diff 112916.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Moved static assert into a .cpp file, DiagnosticIDs.cpp seems like the one that
makes the most sense.
https://reviews.llvm.org/D37122
Files:
include/clang/Basic/Diagnosti
rnk added inline comments.
Comment at: include/clang/Basic/AllDiagnostics.h:37
+#define STRINGIFY_NAME(NAME) #NAME
+#define VALIDATE_DIAG_SIZE(NAME)
\
+ static_assert(
\
erichkeane updated this revision to Diff 112651.
erichkeane added a comment.
Removed file due to git weirdness.
https://reviews.llvm.org/D37122
Files:
include/clang/Basic/AllDiagnostics.h
include/clang/Basic/DiagnosticIDs.h
lib/Basic/DiagnosticIDs.cpp
Index: lib/Basic/DiagnosticIDs.cpp
=
erichkeane added a comment.
In https://reviews.llvm.org/D37122#852018, @rnk wrote:
> In https://reviews.llvm.org/D37122#851978, @erichkeane wrote:
>
> > Ugg... disregard the system-header-line-directive-ms-lineendings.c issue,
> > I'm going to try to figure that out
>
>
> Yeah, I'm seeing is
rnk added a comment.
In https://reviews.llvm.org/D37122#851978, @erichkeane wrote:
> Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm
> going to try to figure that out
Yeah, I'm seeing issues with that as well. I'm not sure what's up.
https://reviews.llvm.org
erichkeane added a comment.
Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm
going to try to figure that out
https://reviews.llvm.org/D37122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
erichkeane created this revision.
Diagnostic Categories are fairly annoying, and are only enforced
by a runtime-debug-only assert. This puts in a touch more work
to get this all done at compile-time with static asserts.
https://reviews.llvm.org/D37122
Files:
include/clang/Basic/AllDiagnostic
