[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith closed this revision. rsmith added a comment. Committed as r311744. https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Sorry for the delay, this looks good to me. https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111840. Rakete marked 2 inline comments as done. Rakete added a comment. Update entry on the C++ status page. https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx2a-poin

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111801. https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx2a-pointer-to-const-ref-member.cpp Index: test/SemaCXX/cxx2a-pointer-to-const-ref-member.cpp

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111800. Rakete added a comment. Rebased because another commit already added the definitions of the C++20 groups. https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx2a-poi

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111719. Rakete marked 3 inline comments as done. Rakete added a comment. Yes please. https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/S

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith added a comment. Thanks, will you need someone to commit this for you? Comment at: include/clang/Basic/DiagnosticGroups.td:794 +// earlier C++ versions. +def CXX20 : DiagGroup<"c++20-extensions">; + We've historically avoided using precise year numbers u

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111602. Rakete added a comment. Thanks! Agreed, your wording is better than mine :) https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/SemaCX

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith added a comment. Oh, and you'll need an accompanying test case before this can be committed (look at the existing tests in test/SemaCXX for ideas). https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith added a comment. Thanks! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4091 "%select{rvalue|lvalue}1">; +def ext_pointer_to_const_ref_member_on_rvalue : ExtWarn< + "pointer-to-member to const& function on an rvalue is a C++2a extension">, I

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete created this revision. This patch allows pointer to const& member functions on rvalues for C++20, and as an extension for prior versions. This is P0704r1 . https://reviews.llvm.org/D36855 Files: include/clang/B