[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added a comment. Huch, seems already submitted. Ignore :> Repository: rL LLVM https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added a comment. Herald added a subscriber: llvm-commits. Ping Repository: rL LLVM https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, Functi

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

cameron314 added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, F

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, Functi

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

cameron314 added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6396 } else { AddTemplateOverloadCandidate(FunTmpl, F.getPair(), ExplicitTemplateArgs, Args, The same slice that was added abov

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

cameron314 added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, F

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

This revision was automatically updated to reflect the committed changes. Closed by commit rL316646: Fix overloaded static functions in SemaCodeComplete (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D36390?vs=111647&id=120374#toc Repository: rL LLVM https://reviews.ll

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. @bkramer Not yet, it would be good to have one though :) https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. Sorry for the long wait, do you have commit access? https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. one more ping... https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. ping 3 https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. one more ping :) https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. ping https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan updated this revision to Diff 111647. yvvan marked 5 inline comments as done. yvvan added a comment. Review comments + solved https://bugs.llvm.org/show_bug.cgi?id=34207 issue. I've also added the extra test for that issue https://reviews.llvm.org/D36390 Files: include/clang/Sema/Sema.h

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} nik wrote: > bkramer wrote: > > assert that FD is a static method. > Just stumbled here because I was looking into

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} bkramer wrote: > assert that FD is a static method. Just stumbled here because I was looking into https://bugs.llvm.

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, I'd prefer something li

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. Please check that one https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. I've just found a regression in my change. in case I have std::string(/*complete here*/) I need to investigate that case because I thought it's covered by !isa(FD) ... https://reviews.llvm.org/D36390 ___ cfe-commits mailing

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan updated this revision to Diff 109980. yvvan added a comment. Yes, I missed to include one file in this diff where it's used https://reviews.llvm.org/D36390 Files: include/clang/Sema/Sema.h lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaOverload.cpp test/Index/complete-call.cpp Index:

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, Shouldn't this be calle

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan created this revision. https://bugs.llvm.org/show_bug.cgi?id=33904 Happens when static function is accessed via the class variable. That leads to incorrect overloads number because the variable is considered as the first argument. struct Bar { static void foo(); static void foo(int);