This revision was automatically updated to reflect the committed changes.
Closed by commit rL310097: CFI: blacklist STL allocate() from unrelated-casts
(authored by vlad.tsyrklevich).
Repository:
rL LLVM
https://reviews.llvm.org/D36294
Files:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
cfe/
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vlad.tsyrklevich marked an inline comment as done.
vlad.tsyrklevich added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:789
+auto *MD = dyn_cast_or_null(D);
+if (MD && MD->getName().equals("allocate") && MD->getNumParams() == 2) {
+ auto *BT = MD->para
vlad.tsyrklevich updated this revision to Diff 109668.
vlad.tsyrklevich marked 2 inline comments as done.
vlad.tsyrklevich added a comment.
Address pcc's comments
https://reviews.llvm.org/D36294
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGen/cfi-unrelated-cast.cpp
Index: test/CodeGen
pcc added a subscriber: cfe-commits.
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:785
+ // Ignore unrelated casts from C++ calls to allocate(). Don't match on the
+ // namespace because not all allocators are in std::
The comment sho
