[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

This revision was automatically updated to reflect the committed changes. Closed by commit rL311199: [clang-diff] Move the JSON export function to clang-diff (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D36178 Files: cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes updated this revision to Diff 109537. johannes added a comment. use %python in tests https://reviews.llvm.org/D36178 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-json.cpp test/lit.cfg test/lit.site.cfg.in tools/clang

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added a comment. @johannes , you have to add %python substitution to lit.cfg, see my attached patch that does it.F4172676: python.diff https://reviews.llvm.org/D36178 ___ cfe-commits mailing list cfe-com

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + arphaman wrote: > johannes wrote: > > johannes wrote: > > > arphaman wrote: > > > > I think you have to use `

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + johannes wrote: > arphaman wrote: > > I think you have to use `%python` instead of `python`, like LLVM tests

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + johannes wrote: > arphaman wrote: > > I think you have to use `%python` instead of `python`, like LLVM tests

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + arphaman wrote: > I think you have to use `%python` instead of `python`, like LLVM tests do. ok So I have to

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + I think you have to use `%python` instead of `python`, like LLVM tests do. https://reviews.llvm.org/D36178

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes updated this revision to Diff 109416. johannes added a comment. getSourceRangeOffsets, test https://reviews.llvm.org/D36178 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-json.cpp tools/clang-diff/ClangDiff.cpp Index: too