[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

2017-07-31 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. This lgtm, we shouldn't defer this until https://reviews.llvm.org/D32842 is done, as that may take a while. https://reviews.llvm.org/D35849 ___ cfe-co

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

2017-07-25 Thread Han Shen via Phabricator via cfe-commits
shenhan added a comment. Thanks for pointing out the relevant CLs. I agree that's the clearer and better solution. (The only concern is that it has been sitting there for 2 months. I'll check back.) In https://reviews.llvm.org/D35849#820473, @vsk wrote: > This won't do the right thing if more

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

2017-07-25 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a reviewer: vsk. vsk added a comment. This won't do the right thing if more than one sanitizer with a default blacklist is enabled. It's also problematic that a default blacklist for one sanitizer can blacklist code for a different sanitizer. See: https://reviews.llvm.org/D32043 https

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

2017-07-25 Thread Han Shen via Phabricator via cfe-commits
shenhan created this revision. This is to provide a default blacklist filename for UBSan. While UBSan is turned on, it's better that clang pick up a blacklist file (when exists), just as what ASan / MSan does, so we do not end up adding the "-fsanitize-blacklist" option to every command line.