[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane closed this revision. erichkeane added a comment. Forgot the svn commit message part, but closed by the related revision. r308530 https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. LGTM. -eric https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. In https://reviews.llvm.org/D35572#813520, @erichkeane wrote: > In https://reviews.llvm.org/D35572#813369, @echristo wrote: > > > Can you update the code in CGBuiltin to use this as part of this patch? :) > > > > Thanks! > > > I'm not sure which you're referring to? I d

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane updated this revision to Diff 107310. erichkeane marked an inline comment as done. erichkeane added a comment. Changed fallthrough for Craig https://reviews.llvm.org/D35572 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp ===

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

craig.topper added inline comments. Comment at: lib/Basic/Targets.cpp:2931 + + // Fallthrough +case CK_Nocona: Use LLVM_FALLTHROUGH? https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane updated this revision to Diff 107183. erichkeane added a comment. Fixed a rebase issue, didn't do anything in CGBuiltin yet. https://reviews.llvm.org/D35572 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp ===

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane added a comment. In https://reviews.llvm.org/D35572#813369, @echristo wrote: > Can you update the code in CGBuiltin to use this as part of this patch? :) > > Thanks! I'm not sure which you're referring to? I don't see a bit in CGBuiltin that checks for a subset of the "Features", h

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. Can you update the code in CGBuiltin to use this as part of this patch? :) Thanks! https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane created this revision. These two functions are really useful for implementations of attributes (including attribute-target), so add the functionality. https://reviews.llvm.org/D35572 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp