This revision was automatically updated to reflect the committed changes.
Closed by commit rL308431: [mips] Teach the driver to accept -m(no-)gpopt.
(authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D35548?vs=107114&id=107275#toc
Repository:
rL LLVM
https://reviews.ll
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
sdardis updated this revision to Diff 107114.
sdardis marked an inline comment as done.
sdardis added a comment.
Addressed review comment, added warning when combining -mabicalls and -mgpopt.
https://reviews.llvm.org/D35548
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/B
sdardis added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:1490
+ GPOpt->claim();
+ }
+
atanasyan wrote:
> Could it be rewritten a bit shorter?
>
> ```
> bool NoAbiCalls =
> ABICalls && ABICalls->getOption().matches(options::OPT_mno_abi
atanasyan added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:1490
+ GPOpt->claim();
+ }
+
Could it be rewritten a bit shorter?
```
bool NoAbiCalls =
ABICalls && ABICalls->getOption().matches(options::OPT_mno_abicalls);
bool WantGPOpt =
sdardis created this revision.
Herald added a subscriber: arichardson.
This patch teaches the driver to pass -mgpopt by default to the backend when it
is supported, i.e. we are using -mno-abicalls.
https://reviews.llvm.org/D35548
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/
