thakis accepted this revision.
thakis marked an inline comment as done.
thakis added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: aaron.ballman.
Herald added a project: All.
landed long ago in 11cafc82b72a80fb9a7266bbda7fc7a0cc1b51a0 /
564004ae78c61a9292a15
arphaman added inline comments.
Comment at: docs/LanguageExtensions.rst:1347
+
+In rare cases, the availability annotation on an API might be overly
+conservative. For example, ``[NSProcessInfo processInfo]`` secretly responds
to
thakis wrote:
> arphaman wrote:
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: docs/LanguageExtensions.rst:1278
+It is possible use the newest SDK but still build a program that can run on
+older macOS and iOS versions, by passing ``-mmacosx-version-info=`` /
+``--miphoneos-v
sdy added inline comments.
Comment at: docs/LanguageExtensions.rst:1278
+It is possible use the newest SDK but still build a program that can run on
+older macOS and iOS versions, by passing ``-mmacosx-version-info=`` /
+``--miphoneos-version-min=``.
thakis wrote
thakis added a comment.
I went ahead and landed this in r308044, given that I addressed the nits and
removed the possibly contentious bits. Happy to address remaining nits in a
follow-up.
https://reviews.llvm.org/D35379
___
cfe-commits mailing lis
thakis added a comment.
Mostly done, thanks!
Comment at: docs/LanguageExtensions.rst:1274
+Objective-C @available
+--
sdy wrote:
> sdy wrote:
> > I think "Objective-C" is redundant, this is already in the ObjC section and
> > most of the
thakis updated this revision to Diff 106652.
thakis marked 3 inline comments as done.
thakis added a comment.
sdy comments
https://reviews.llvm.org/D35379
Files:
docs/LanguageExtensions.rst
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
=
sdy added inline comments.
Comment at: docs/LanguageExtensions.rst:1274
+Objective-C @available
+--
I think "Objective-C" is redundant, this is already in the ObjC section and
most of the other headers don't start with "Objective-C".
thakis updated this revision to Diff 106650.
thakis marked an inline comment as done.
thakis added a comment.
arphaman comments
https://reviews.llvm.org/D35379
Files:
docs/LanguageExtensions.rst
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
thakis marked 7 inline comments as done.
thakis added a comment.
Thanks, all done, much better!
Comment at: docs/LanguageExtensions.rst:1347
+
+In rare cases, the availability annotation on an API might be overly
+conservative. For example, ``[NSProcessInfo processInfo]`` secr
arphaman added a comment.
Thanks for doing this! I have some comments:
Comment at: docs/LanguageExtensions.rst:1277
+It is possible use the newest SDK but still build a program that can run on
+older macOS and iOS versions, by passing ``-mmacosx-version-info=`` /
thakis updated this revision to Diff 106528.
thakis marked an inline comment as done.
thakis added a comment.
Document *, add example with multiple platforms
https://reviews.llvm.org/D35379
Files:
docs/LanguageExtensions.rst
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDo
erik.pilkington added inline comments.
Comment at: docs/LanguageExtensions.rst:1309
+ void my_fun(NSSomeClass* var) {
+if (@available(macOS 10.12)) {
+ [var fancyNewMethod];
thakis wrote:
> erik.pilkington wrote:
> > Don't forget the '*', ie @available(
thakis added inline comments.
Comment at: docs/LanguageExtensions.rst:1290
-.. _langext-overloading:
-
erik.pilkington wrote:
> did you mean to remove this?
I meant to move it above the "protocol-qualifier mangling of parameters"
section; I think that's where
thakis updated this revision to Diff 106513.
thakis marked an inline comment as done.
thakis added a comment.
comments
https://reviews.llvm.org/D35379
Files:
docs/LanguageExtensions.rst
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
=
erik.pilkington added a reviewer: arphaman.
erik.pilkington added a subscriber: arphaman.
erik.pilkington added a comment.
This looks great, thanks for working on this! LGTM, but @arphaman might have
some thoughts.
Comment at: docs/LanguageExtensions.rst:1290
-.. _langext-ov
thakis created this revision.
Based on
https://devstreaming-cdn.apple.com/videos/wwdc/2017/411a7o9phe4uekm/411/411_whats_new_in_llvm.pdf
(I couldn't find a way to play the corresponding video on linux, so I didn't
look at that.)
https://reviews.llvm.org/D35379
Files:
docs/LanguageExtension
17 matches
Mail list logo
