chapuni added inline comments.
Comment at: test/CMakeLists.txt:34
+ ${CMAKE_CURRENT_BINARY_DIR}
+ DEPENDS ${LIBUNWIND_TEST_DEPS}
+ )
Could you fill this, please?
set(LIBUNWIND_TEST_DEPS
unwind
)
It makes "check-unwind" pass from clean.
https://re
EricWF added a comment.
> Checking out libcxx should not be a requirement since libunwind should be
> usable independently on libcxx.
Nope, Sorry. As jroelofs said the code duplication is not worth it.
Unfortunately you'll need the libc++ sources, and I also don't think that's a
bug.
https:/
jroelofs added inline comments.
Comment at: test/lit.cfg:36
+else:
+lit_config.fatal('Could not find libcxx test directory for test imports'
+ ' in: %s' % libcxx_test_src_root)
manojgupta wrote:
> jroelofs wrote:
> > manojgupta wrote:
> >
manojgupta added inline comments.
Comment at: test/lit.cfg:36
+else:
+lit_config.fatal('Could not find libcxx test directory for test imports'
+ ' in: %s' % libcxx_test_src_root)
jroelofs wrote:
> manojgupta wrote:
> > I do not have libcxx
jroelofs added inline comments.
Comment at: test/lit.cfg:36
+else:
+lit_config.fatal('Could not find libcxx test directory for test imports'
+ ' in: %s' % libcxx_test_src_root)
manojgupta wrote:
> I do not have libcxx checked out since I a
manojgupta added inline comments.
Comment at: test/lit.cfg:36
+else:
+lit_config.fatal('Could not find libcxx test directory for test imports'
+ ' in: %s' % libcxx_test_src_root)
I do not have libcxx checked out since I am want to use only
jroelofs closed this revision.
jroelofs added a comment.
r307266
https://reviews.llvm.org/D35038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM. I'm assuming it works but we can iron out the kinks once it lands.
We should probably add builders that run the tests as well.
Comment at: test/lit.cfg:46
+li
jroelofs created this revision.
Herald added a subscriber: mgorny.
Mostly cargo-culted from libcxxabi, since the unwinder was forked from there in
the first place.
Might still be some cruft that's only applicable to libcxxabi in here, so let
me know if you spot anything like that. I killed some
