This revision was automatically updated to reflect the committed changes.
Closed by commit rL309901: [coverage] Make smaller regions for the first case
of a switch. (authored by efriedma).
Changed prior to commit:
https://reviews.llvm.org/D34801?vs=104581&id=109456#toc
Repository:
rL LLVM
h
vsk added a comment.
In https://reviews.llvm.org/D34801#828382, @efriedma wrote:
> I'm going to look over the overall algorithm one more time to make sure this
> direction makes sense. The current code for ending regions on
> break/continue/return/noreturn doesn't really work well,
Maybe it's
efriedma added a comment.
I'm going to look over the overall algorithm one more time to make sure this
direction makes sense. The current code for ending regions on
break/continue/return/noreturn doesn't really work well, and the way we handle
multiple consecutive case statments isn't really r
vsk added a comment.
Hi Eli, are you waiting on something before landing this?
Repository:
rL LLVM
https://reviews.llvm.org/D34801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks for the patch! LGTM.
Comment at: lib/CodeGen/CoverageMappingGen.cpp:686
+// FIXME: a break in a switch should terminate regions for all preceding
+// case statements
