This revision was automatically updated to reflect the committed changes.
Closed by commit rL306555: [Bash-autocompletion] Check clang version in Bash
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34607?vs=103884&id=104435#toc
Repository:
rL LLVM
https://review
teemperor accepted this revision.
teemperor added a comment.
Works as intended, good job!
https://reviews.llvm.org/D34607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
yamaguchi updated this revision to Diff 103884.
yamaguchi added a comment.
Update patch.
https://reviews.llvm.org/D34607
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
===
--- clang/utils/bash-a
ruiu added inline comments.
Comment at: clang/utils/bash-autocomplete.sh:28
+ flags=$( clang --autocomplete="$arg" 2>/dev/null )
+ # Check if --autocomplete is supported in user's clang version.
+ if [[ "$?" != 0 ]]; then
It is probably a bit better if you men
yamaguchi created this revision.
Add check if user's clang version supports --autocomplete or not.
If not, we just autocomplete files.
https://reviews.llvm.org/D34607
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
