This revision was automatically updated to reflect the committed changes.
Closed by commit rL308218: [AArch64] Add support for __builtin_ms_va_list on
aarch64 (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D34475?vs=106701&id=106941#toc
Repository:
rL LLVM
https:/
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, looks great!
https://reviews.llvm.org/D34475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mstorsjo added a comment.
Reid, with https://reviews.llvm.org/D34474 approved, does this look like what
you had in mind?
https://reviews.llvm.org/D34475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
mstorsjo updated this revision to Diff 106701.
mstorsjo added a comment.
Updated for the new version of https://reviews.llvm.org/D34474.
https://reviews.llvm.org/D34475
Files:
include/clang-c/Index.h
include/clang/Basic/Builtins.def
include/clang/Basic/BuiltinsX86.def
include/clang/Basi
mstorsjo updated this revision to Diff 106690.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Initial attempt at unifying the use of __builtin_ms_va_list and calling
conventions between x86_64 and aarch64. This goes with the current (un-unified)
version of https://review
rnk added inline comments.
Comment at: include/clang/Basic/BuiltinsAArch64.def:65
+// Win64-compatible va_list functions
+BUILTIN(__builtin_ms_va_start, "vc*&.", "nt")
+BUILTIN(__builtin_ms_va_end, "vc*&", "n")
mstorsjo wrote:
> rnk wrote:
> > I strongly suspect
mstorsjo added inline comments.
Comment at: include/clang/Basic/BuiltinsAArch64.def:65
+// Win64-compatible va_list functions
+BUILTIN(__builtin_ms_va_start, "vc*&.", "nt")
+BUILTIN(__builtin_ms_va_end, "vc*&", "n")
rnk wrote:
> I strongly suspect that Microsoft
rnk added inline comments.
Comment at: include/clang/Basic/BuiltinsAArch64.def:65
+// Win64-compatible va_list functions
+BUILTIN(__builtin_ms_va_start, "vc*&.", "nt")
+BUILTIN(__builtin_ms_va_end, "vc*&", "n")
I strongly suspect that Microsoft will never adopt a
mstorsjo updated this revision to Diff 106489.
mstorsjo retitled this revision from "[RFC] [AArch64] Add support for
__builtin_ms_va_list on aarch64" to "[AArch64] Add support for
__builtin_ms_va_list on aarch64".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Added test
