This revision was automatically updated to reflect the committed changes.
Closed by commit rL305890: Moved code hanlding precompiled preamble out of the
ASTUnit. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34287?vs=103216&id=103338#toc
Repository:
rL LLVM
htt
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D34287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:124
+/// CanReusePreamble + AddImplicitPreamble to make use of it.
+class PrecompiledPreamble {
+public:
klimek wrote:
> ilya-biryukov wrote:
> > klimek wrote:
> > > If
ilya-biryukov updated this revision to Diff 103216.
ilya-biryukov added a comment.
- Made TempPCHFile an inner class of PrecompiledPreamble.
- Made PreambleFileHash an inner class of PrecompiledPreamble.
- Changed stanalone functions to members.
- Removed some member accessors that were no longer
klimek added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:124
+/// CanReusePreamble + AddImplicitPreamble to make use of it.
+class PrecompiledPreamble {
+public:
ilya-biryukov wrote:
> klimek wrote:
> > If a user doesn't care about t
ilya-biryukov updated this revision to Diff 103203.
ilya-biryukov added a comment.
Removed PossiblyOwnedBuffer, added an extra copy instead.
This makes the code much simpler.
https://reviews.llvm.org/D34287
Files:
include/clang/Frontend/ASTUnit.h
include/clang/Frontend/PrecompiledPreamble.h
klimek added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:131-136
+/// \brief Get a source buffer for \p MainFilePath, handling all file-to-file
+/// and file-to-buffer remappings inside \p Invocation.
+static PossiblyOwnedBuffer
+getBufferForFileHandlingRemapping(const
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:42-43
+/// destructors.
+/// An assertion will fire if two PCHTempFiles are created with the same name,
+/// so it's not intended to be used outside preamble-handling.
+class TempPCHFile
ilya-biryukov updated this revision to Diff 103053.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Added default initializers to PreambleFileHash.
- Update file comments to address klimek's questions.
https://reviews.llvm.org/D34287
Files:
include/clang/Front
klimek added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:42-43
+/// destructors.
+/// An assertion will fire if two PCHTempFiles are created with the same name,
+/// so it's not intended to be used outside preamble-handling.
+class TempPCHFile {
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:248
+/// doesn't restore the state \p CI had before calling AddImplicitPreamble,
only
+/// clears relevant settings, so that preamble is disabled in \p CI.
+} // namespace clang
---
ilya-biryukov updated this revision to Diff 102993.
ilya-biryukov added a comment.
Removed a stray comment (of a previously removed declaration).
https://reviews.llvm.org/D34287
Files:
include/clang/Frontend/ASTUnit.h
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/ASTUnit.cpp
arphaman added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:248
+/// doesn't restore the state \p CI had before calling AddImplicitPreamble,
only
+/// clears relevant settings, so that preamble is disabled in \p CI.
+} // namespace clang
ilya-biryukov created this revision.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D34287
Files:
include/clang/Frontend/ASTUnit.h
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/CMakeLists.txt
lib/Frontend/PrecompiledPreamble.cpp
Index:
14 matches
Mail list logo
