[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2020-05-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I think we can abandon this revision now we support --style=file: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34252/new/ https://reviews.llvm.org/D34252 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2019-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I recently hit this issue where I was clang-formatting generated code out of a source tree, which was then copied into a source tree. This failed my post build clang-format validation check and I couldn't understand why. it was only later I realised that unless I

Re: [PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2017-06-19 Thread Manuel Klimek via cfe-commits
On Fri, Jun 16, 2017 at 8:26 PM Dan Ciliske via Phabricator < revi...@reviews.llvm.org> wrote: > dciliske added a comment. > > So... how should I get something added? That patch has been sitting for a > couple weeks. > > Should I work on that patch? If so, how do I work on it? This is the first >

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2017-06-16 Thread Dan Ciliske via Phabricator via cfe-commits
dciliske added a comment. So... how should I get something added? That patch has been sitting for a couple weeks. Should I work on that patch? If so, how do I work on it? This is the first time I'm working on a large OSS project. https://reviews.llvm.org/D34252

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2017-06-16 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Hi Dan, thanks for the patch! https://reviews.llvm.org/D33560, which adds the same feature, is already under review :) https://reviews.llvm.org/D34252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2017-06-15 Thread Dan Ciliske via Phabricator via cfe-commits
dciliske created this revision. Herald added a subscriber: klimek. The Format library has no way to specify a specific file to be used as the style source. It climbs the path looking for ‘.clang_format’. This patch adds the ability to specify a specific file to use for clang Format utilities. T