[PATCH] D34237: Mark the operations of __wrap_iter as constexpr

2017-06-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. A large portion of this patch is UB. Any function that unconditionally calls `__get_db()` can never be a valid constant expression, hence UB. Is there a smaller set of operations or `__wrap_iter` that *must* be made constexpr? Or do they all need to be? ==

[PATCH] D34237: Mark the operations of __wrap_iter as constexpr

2017-06-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Could you re-upload this with a updated diff against trunk, and one with more context. https://reviews.llvm.org/D34237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D34237: Mark the operations of __wrap_iter as constexpr

2017-06-15 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists created this revision. `__wrap_iter` is an internal libc++ class used to, well, wrap other iterators (such as pointers) when we need or want an object type. Mark the operations on `__wrap_iter` as constexpr, so that they can be used in a constexpr context if the underlying iterator