This revision was automatically updated to reflect the committed changes.
Closed by commit rL335284: [LTO] Enable module summary emission by default for
regular LTO (authored by tobiasvk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
tejohnson accepted this revision.
tejohnson added a comment.
LGTM with following suggestions.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:776
+ bool EmitLTOSummary =
+ (CodeGenOpts.PrepareForLTO && !CodeGenOpts.PrepareForThinLTO &&
+ llvm::Triple(TheModule->getTar
tobiasvk added a comment.
@pcc, @tejohnson: Are you OK with this going in now that
https://reviews.llvm.org/D47898 has merged?
https://reviews.llvm.org/D34156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
tobiasvk updated this revision to Diff 150965.
tobiasvk added a comment.
- Rebase for current tree
- Fix -flto -save-temps which the previous patch broke
https://reviews.llvm.org/D34156
Files:
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/Code
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#1125489, @vlad.tsyrklevich wrote:
> Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
> revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix
> under review in https://reviews.llvm.org/D478
vlad.tsyrklevich added a comment.
Herald added a subscriber: steven_wu.
Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix under
review in https://reviews.llvm.org/D47898. This revision needs to be
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#781415, @pcc wrote:
> Please confirm that we can still self host with full LTO now that
> https://reviews.llvm.org/D33922 has landed.
Good point. And the answer seems to be no :/
ld.lld: .../llvm/lib/Linker/IRMover.cpp:242: llvm::
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
Please confirm that we can still self host with full LTO now that
https://reviews.llvm.org/D33922 has landed.
LGTM otherwise. Thanks!
https://reviews.llvm.org/D34156
___
