This revision was automatically updated to reflect the committed changes.
Closed by commit rL305298: [clangd] Store references instead of unique_ptrs in
ClangdServer. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34148?vs=102333&id=102344#toc
Repository:
rL LLVM
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
But, of course, that can be done in a separate commit.
https://reviews.llvm.org/D34148
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
krasimir added inline comments.
Comment at: clangd/ClangdLSPServer.h:75
+ LSPDiagnosticsConsumer DiagConsumer;
+ RealFileSystemProvider FSProvider;
+
This approach is still inflexible. I'd make ClangdLSPServer : public
DiagnosticsConsumer and pass references t
ilya-biryukov created this revision.
ClangdServer was owning objects passed to it in constructor for no good reason.
Lots of stuff was moved from the heap to the stack thanks to this change.
https://reviews.llvm.org/D34148
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/
