[PATCH] D33640: clang-format: [JS] fix indenting bound functions.

2017-05-29 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304135: clang-format: [JS] fix indenting bound functions. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D33640?vs=100589&id=100591#toc Repository: rL LLVM https://reviews.

[PATCH] D33640: clang-format: [JS] fix indenting bound functions.

2017-05-29 Thread Martin Probst via Phabricator via cfe-commits
mprobst updated this revision to Diff 100589. mprobst added a comment. - fix comment https://reviews.llvm.org/D33640 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ==

[PATCH] D33640: clang-format: [JS] fix indenting bound functions.

2017-05-29 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/ContinuationIndenter.cpp:210 // FIXME: We should find a more generic solution to this problem. - !(State.Column <= NewLineColumn && P

[PATCH] D33640: clang-format: [JS] fix indenting bound functions.

2017-05-29 Thread Martin Probst via Phabricator via cfe-commits
mprobst updated this revision to Diff 100588. mprobst added a comment. - fix comment https://reviews.llvm.org/D33640 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ==

[PATCH] D33640: clang-format: [JS] fix indenting bound functions.

2017-05-29 Thread Martin Probst via Phabricator via cfe-commits
mprobst created this revision. Herald added a subscriber: klimek. The previous fix to force build style wrapping if the previous token is a closing parenthesis broke a peculiar pattern where users parenthesize the function declaration in a bind call: fn((function() { ... }).bind(this)); This