This revision was automatically updated to reflect the committed changes.
Closed by commit rL317398: CodeGenCXX: no default dllimport storage for mingw
(authored by martell).
Changed prior to commit:
https://reviews.llvm.org/D33620?vs=100523&id=121578#toc
Repository:
rL LLVM
https://reviews
mstorsjo added a comment.
After trying to build a bit more code with clang and a static libcxx, I agree
with this change, so +1 from me. @compnerd ?
Repository:
rL LLVM
https://reviews.llvm.org/D33620
___
cfe-commits mailing list
cfe-commits@lis
mstorsjo added a comment.
Does this break things for current users of clang as a drop-in replacement for
gcc in mingw setups, while using e.g. a gcc provided `libstdc++-6.dll`? OTOH,
removing dllimport usually isn't too much of an issue - the calls go via thunks
which is non-ideal and theoretic
rnk added a comment.
Saleem, didn't something change here two months ago? Why do we want to bother
with all of this dllimport stuff in the frontend? It seems to break mingw and
add complexity for very little gain (avoiding linker provided thunks).
Repository:
rL LLVM
https://reviews.llvm.or
martell created this revision.
GNU frontends don't have options like `/MT`, `/MD` etc so it makes little sense.
This fixes a few link error regressions with libc++ and libc++abi
Repository:
rL LLVM
https://reviews.llvm.org/D33620
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/runti
