This revision was automatically updated to reflect the committed changes.
Closed by commit rL305061: Speed up preamble loading (authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D33493?vs=101995&id=102003#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33493
Files:
yvvan updated this revision to Diff 101995.
yvvan added a comment.
"what kind of performance benefits do you get for the preamble load times?"
In cases where many windows headers are included preamble loading takes almost
the half of reparse time. With this fix time to load preamble goes towards
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM with one inline request below.
I also have a question: what kind of performance benefits do you get for the
preamble load times?
Comment at: lib/Frontend/ASTUnit.c
yvvan updated this revision to Diff 101865.
yvvan added a comment.
Improve commentary. Use StringMap
https://reviews.llvm.org/D33493
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
Index: lib/Frontend/ASTUnit.cpp
===
arphaman added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:1152
+ else
+SrcLocCache.clear();
yvvan wrote:
> arphaman wrote:
> > Why is `clear` in an `else` here? We always create a new `SourceManager` in
> > this function, so the previously cach
yvvan added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:192
+ /// of that loading
+ std::map SrcLocCache;
+
arphaman wrote:
> You can use an `llvm::StringMap` instead.
I will change that
Comment at: lib/Frontend/ASTUnit.cpp:
arphaman added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:192
+ /// of that loading
+ std::map SrcLocCache;
+
You can use an `llvm::StringMap` instead.
Comment at: lib/Frontend/ASTUnit.cpp:1152
+ else
+SrcLocCache.clea
yvvan added a comment.
In https://reviews.llvm.org/D33493#774264, @arphaman wrote:
> Can you use a local map in `TranslateStoredDiagnostics` instead of storing
> one in the `ASTUnit`, or do you need to keep it around?
The whole purpose is to use it between different TranslateStoredDiagnostics
arphaman added a comment.
Can you use a local map in `TranslateStoredDiagnostics` instead of storing one
in the `ASTUnit`, or do you need to keep it around?
https://reviews.llvm.org/D33493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
yvvan updated this revision to Diff 101533.
yvvan added a comment.
Remove global completion cache part because it's probably not always valid.
https://reviews.llvm.org/D33493
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
Index: lib/Frontend/ASTUnit.cpp
=
yvvan updated this revision to Diff 100605.
yvvan added a comment.
diff with -U
https://reviews.llvm.org/D33493
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
Index: lib/Frontend/ASTUnit.cpp
===
--- lib/
arphaman added a comment.
Please post the patch with full context `git diff -U`.
https://reviews.llvm.org/D33493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yvvan updated this revision to Diff 100075.
yvvan added a comment.
fix member variable name, add comments
https://reviews.llvm.org/D33493
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
Index: lib/Frontend/ASTUnit.cpp
==
yvvan created this revision.
On Windows loading preamble and caching global completion takes a while.
This is the way to improve it.
Please comment if I misuse something.
https://reviews.llvm.org/D33493
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
Index: lib/Frontend/A
14 matches
Mail list logo
