kparzysz marked an inline comment as done.
kparzysz added inline comments.
Comment at: cfe/trunk/lib/CodeGen/CodeGenFunction.h:3756
///
/// \param Source - If non-null, this will be initialized with
/// information about the source of the alignment. Note that this
---
chapuni added inline comments.
Comment at: cfe/trunk/lib/CodeGen/CodeGenFunction.h:3756
///
/// \param Source - If non-null, this will be initialized with
/// information about the source of the alignment. Note that this
Could you update this? See als
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303358: [CodeGen] Propagate LValueBaseInfo instead of
AlignmentSource (authored by kparzysz).
Changed prior to commit:
https://reviews.llvm.org/D33284?vs=99353&id=99457#toc
Repository:
rL LLVM
https
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Yes, of course. Although "looks good to me" is acceptance whether or not I
actually push a button in Phabricator. :)
Repository:
rL LLVM
https://reviews.llvm.org/D33284
___
kparzysz added a comment.
If you have no further comments, could you accept this review?
Repository:
rL LLVM
https://reviews.llvm.org/D33284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rjmccall added a comment.
In https://reviews.llvm.org/D33284#757917, @kparzysz wrote:
> Changed the getNatural.*TypeAlignment to produce the entire LValueBaseInfo,
> assuming MayAlias to be false.
>
> Added merging of LValueBaseInfos. The merging assumes that the alignment
> source in the para
kparzysz updated this revision to Diff 99353.
kparzysz marked 2 inline comments as done.
kparzysz added a comment.
Changed the getNatural.*TypeAlignment to produce the entire LValueBaseInfo,
assuming MayAlias to be false.
Added merging of LValueBaseInfos. The merging assumes that the alignment
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2256
Address(CapLVal.getPointer(), getContext().getDeclAlign(VD)),
-CapLVal.getType(), AlignmentSource::Decl);
+CapLVal.getType(), LValueBaseInfo(AlignmentSource::Decl,
MayAli
kparzysz added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2256
Address(CapLVal.getPointer(), getContext().getDeclAlign(VD)),
-CapLVal.getType(), AlignmentSource::Decl);
+CapLVal.getType(), LValueBaseInfo(AlignmentSource::Decl,
MayAli
rjmccall added a comment.
Generally looks great, thanks!
Comment at: lib/CodeGen/CGBlocks.cpp:923
+ MakeAddrLValue(blockField, type,
+ LValueBaseInfo(AlignmentSource::Decl, false)),
/*captured by init*/ false);
-
kparzysz created this revision.
The functions creating LValues propagated information about alignment source.
Extend the propagated data to also include information about possible
unrestricted aliasing. A new class LValueBaseInfo will contain both
AlignmentSource and MayAlias info.
Thi
11 matches
Mail list logo
