This revision was automatically updated to reflect the committed changes.
Closed by commit rL303267: clang-cl: Fix path-based MSVC version detection
(authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D33258?vs=99213&id=99310#toc
Repository:
rL LLVM
https://reviews.llvm.or
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D33258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans updated this revision to Diff 99213.
hans added a comment.
Addressing comments.
https://reviews.llvm.org/D33258
Files:
lib/Driver/ToolChains/MSVC.cpp
Index: lib/Driver/ToolChains/MSVC.cpp
===
--- lib/Driver/ToolChains/MSVC
rnk added a comment.
I'd rather not hardcode all the msvc archs. IMO we should just look up one
level and check if that's called bin, and continue if so. I think I had:
bool IsBin = llvm::sys::path::filename(PathEntry).compare_lower("bin");
if (!IsBin) {
PathEntry = llvm::sys::path::pare
hans added a subscriber: thakis.
hans added a comment.
Nico asked about tests. This whole thing landed (r297851) without tests, and
I'm not sure it's worth the effort adding one for this :-/
https://reviews.llvm.org/D33258
___
cfe-commits mailing l
hans created this revision.
The code wasn't taking the architecture-specific subdirectory into account.
https://reviews.llvm.org/D33258
Files:
lib/Driver/ToolChains/MSVC.cpp
Index: lib/Driver/ToolChains/MSVC.cpp
===
--- lib/Dri
