This revision was automatically updated to reflect the committed changes.
Closed by commit rL303325: Fix an assertion failure in
FormatASTNodeDiagnosticArgument. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D33207?vs=99112&id=99386#toc
Repository:
rL LLVM
https://
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D33207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
alexfh added inline comments.
Comment at: test/SemaCXX/warn-shadow.cpp:214
+void handleLinkageSpec() {
+ typedef void externC; // expected-warning {{declaration shadows a typedef in
linkage specification}}
+}
rsmith wrote:
> We should be producing a diagnostic
alexfh updated this revision to Diff 99112.
alexfh added a comment.
Herald added a subscriber: krytarowski.
Instead of handling LinkageSpecDecl, use getRedeclContext() when issuing
-Wshadow diagnostic.
https://reviews.llvm.org/D33207
Files:
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-shadow.cp
rsmith added inline comments.
Comment at: test/SemaCXX/warn-shadow.cpp:214
+void handleLinkageSpec() {
+ typedef void externC; // expected-warning {{declaration shadows a typedef in
linkage specification}}
+}
We should be producing a diagnostic talking about th
alexfh added a comment.
The patch is trivial, I'm mostly wondering about the wording and whether we
want to expand the "linkage specification" to specify whether it is `extern
"C"` or `extern "C++"`, for example.
https://reviews.llvm.org/D33207
__
alexfh created this revision.
The test being added in this patch used to cause an assertion failure:
/build/./bin/clang -cc1 -internal-isystem /build/lib/clang/5.0.0/include
-nostdsysteminc -verify -fsyntax-only -std=c++11 -Wshadow-all
/src/tools/clang/test/SemaCXX/warn-shadow.cpp
-
