[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-08-29 Thread Jan Wilken Dörrie via Phabricator via cfe-commits
jdoerrie added a comment. Thanks for applying a fix based on my patch! I could have sworn the added tests failed locally before applying the algorithm patch, though... oh well. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commit

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-08-28 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I committed as r311952 which fixes this - based on Jan's suggestion, but not quite the same as this patch. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-08-27 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. Note: I suspect that the proposed change to `` fixes the problem, but the new tests don't check that. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-08-27 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I applied the test change, but not the algorithm change, and the tests passed. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-05-10 Thread Jan Wilken Dörrie via Phabricator via cfe-commits
jdoerrie added a comment. Ping, please take a look at this. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-05-03 Thread Jan Wilken Dörrie via Phabricator via cfe-commits
jdoerrie added inline comments. Comment at: include/algorithm:4471 _RBi(__middle), _RBi(__first), _RBi(__last), __negate<_Compare>(__comp)); } As marshall pointed out in https://bugs.llvm.org//show_

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

2017-05-03 Thread Jan Wilken Dörrie via Phabricator via cfe-commits
jdoerrie created this revision. This change fixes std::inplace_merge to be stable for all inputs and adds corresponding tests. Fixes Bug 31166: https://bugs.llvm.org//show_bug.cgi?id=31166 https://reviews.llvm.org/D32788 Files: include/algorithm test/std/algorithms/alg.sorting/alg.merge/i