[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL305224: Correct debug info bit offset calculation for big-endian targets (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D32745?vs=97773&id=102233#toc Repository: rL LLVM https:

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej added a comment. Ping, I don't have have commit permissions, so I am at the mercy of others for getting this fix committed... https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej updated this revision to Diff 97773. frej added a comment. Removed 'REQUIRES'-line. https://reviews.llvm.org/D32745 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/mips-debug-info-bitfield.c Index: clang/test/CodeGen/mips-debug-info-bitfield.c

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

rnk accepted this revision. rnk added a comment. Looks good without the REQUIRES line, thanks for the fix! It's unfortunate that this logic is here and in CodeGen/AsmPrinter/DwarfUnit.cpp, but such is life. https://reviews.llvm.org/D32745 ___ cfe-

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

aprantl added a comment. Ah. Thanks for clarifying! We should remove it, then. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

rnk added a comment. In https://reviews.llvm.org/D32745#744292, @frej wrote: > In https://reviews.llvm.org/D32745#744280, @rnk wrote: > > > The REQUIRES tag is unnecessary. Clang can emit IR for any target without a > > registered backed. > > > So should I drop it? It doesn't hurt does it? Som

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej added a comment. In https://reviews.llvm.org/D32745#744280, @rnk wrote: > The REQUIRES tag is unnecessary. Clang can emit IR for any target without a > registered backed. So should I drop it? It doesn't hurt does it? https://reviews.llvm.org/D32745 ___

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

rnk added a comment. The REQUIRES tag is unnecessary. Clang can emit IR for any target without a registered backed. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej updated this revision to Diff 97544. frej added a comment. Added missing "REQUIRES: mips-registered-target". https://reviews.llvm.org/D32745 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/mips-debug-info-bitfield.c Index: clang/test/CodeGen/mips-debug-info-bitfield.c ===

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Doesn't the test need some kind of `REQUIRES: mips` line? Otherwise looks fine. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cf

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej created this revision. Herald added subscribers: arichardson, aprantl. The change "[CodeView] Implement support for bit fields in Clang" (r274201, https://reviews.llvm.org/rL274201) broke the calculation of bit offsets for the debug info describing bitfields on big-endian targets. Prior to c