This revision was automatically updated to reflect the committed changes.
Closed by commit rL300921: [libc++] Default to vcruntime when targeting MSVC
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D32320?vs=96055&id=96056#toc
Repository:
rL LLVM
https://reviews.ll
smeenai updated this revision to Diff 96055.
smeenai added a comment.
Reduce nesting (address comments)
https://reviews.llvm.org/D32320
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -1
smeenai added inline comments.
Comment at: CMakeLists.txt:119
+set(LIBCXX_CXX_ABI_LIBNAME "vcruntime")
else()
+find_path(
EricWF wrote:
> Nit: I would rather see this be
> ```
> elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND
> IS_D
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: CMakeLists.txt:119
+set(LIBCXX_CXX_ABI_LIBNAME "vcruntime")
else()
+find_path(
Nit: I would rather see this be
```
elseif ((NOT
smeenai created this revision.
Herald added a subscriber: mgorny.
libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it
targets the Itanium ABI, whereas MSVC uses the Microsoft ABI. Make the
default ABI be vcruntime when targeting MSVC even if libc++abi is
present in the tree.
