[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

2017-04-21 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 96120. krasimir added a comment. - Introduce a proper abstraction https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp lib/Format/UnwrappedLineFormatter.h test/Format/inc

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

2017-04-21 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:845 + if (!Invalid) +os << " This might be due to a syntax error at line " << LineNumber + << "."; djasper wrote: > I wonder whether this might be confusing w

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

2017-04-21 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 96115. krasimir marked an inline comment as done. krasimir added a comment. - Removed double declaration https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp lib/Format/Unw

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

2017-04-21 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 96113. krasimir added a comment. - Address review comments https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp lib/Format/UnwrappedLineFormatter.h test/Format/incomplete

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

2017-04-20 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: include/clang/Format/Format.h:1527 +/// non-recoverable syntax error. tooling::Replacements reformat(const FormatStyle &Style, StringRef Code, ArrayRef Ranges, This is a public interface