[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-06-01 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: test/Driver/linux-ld.c:467-471 +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-everest-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-pure64-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=i686-isoft-linux +// RUN:

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-24 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 96497. xiangzhai added a comment. Hi Saleem, Please check whether or not "the correct GCC search dir" for x86_64-isoft-linux firstly, please point out my fault, thanks! And sysroot structure shown as: $ tree clang/test/Driver/Inputs/isoft_linux_4_tree

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-24 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai added a comment. Hi Saleem, Thanks for pointing out my fault, I will update my patch to add, for example: -L[[SYSROOT]]/usr/lib/gcc/x86_64-isoft-linux/6.3.1 to the testcase. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D32269 ___

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-24 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Is this to actually get the correct GCC search dir? Your test doesnt really test anything AFAICT, as it is just invoking clang with a target that it would accept anyways. Repo

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-20 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 96088. xiangzhai added a comment. Hi Richard, Thanks for your review! I updated my patch as you suggested: add some test coverage for these triples, and I run `make check-clang-driver` for verification, please point out my fault, thanks! Regards, Leslie

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-20 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. Please add some test coverage for these triples. Repository: rL LLVM https://reviews.llvm.org/D32269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai created this revision. Hi LLVM developers, I am a Linux engineer of operating system department at iSOFT , I want to add iSOFTLinux to GNU ToolChains X86Triple, please review my patch, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM h