[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. Committed r304541 & r304542. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. Sorry for the delay, was on vacation. Committing today. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. Ok, I will commit them sometime this week then. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. @arphaman Those patches seem reasonable. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. While I do agree that these tests would be better off in another place, we currently don't have the bandwidth to facilitate that move. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. @jroelofs I've managed to put together a solution that adds REQUIRES to the tests that ensure they only work with the latest SDK (10.12). F3339761: macOSsdk.diff F3339760: sdkUtilLLVM.diff WDYT?

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. Sure. That'd be needed whether they stay, or get moved to test-suite. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. @jroelofs We'd be ok with tying the test to a specific SDK and maintaining that tie (e.g. bumping it upstream). I was planning to investigate how to make the SDK version checks work, but I don't have the time ATM. Can I get back to you in a week? https://reviews.llvm

[PATCH] D32178: Delete unstable integration tests

rsmith added a comment. Clang's regression test suite is not a sensible home for these tests. We should have a home and a plan for system-specific integration tests, but this is not it. Perhaps this should instead be a part of LNT / the test-suite project? https://reviews.llvm.org/D32178 __

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. ping @arphaman https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. Ping. @arphaman I'd like to remove them, absent a concrete plan to fix this from folks with a vested interest in them (i.e. you). https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. I think you'd have to check for a maximum host SDK version, and then bump it upstream every time there's a new one thats known to work with the then-current trunk. It can't be done based on language features because by definition, one cannot know what features are goi

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. Thanks for working on this! We had some more discussion about these tests yesterday, and we would prefer to keep them actually. We might want to use something like `REQUIRES` instead, but right now we are still not sure what to check for. https://reviews.llvm.org/D32

[PATCH] D32178: Delete unstable integration tests

jroelofs created this revision. These tests are breaking when tested under the upstream 3.8.1 release + the 10.12 / 16C58 sdk. They use headers from the host SDKs, so they are not stable with respect to adding new language features, such as class `@properties`. Regression tests should not depen