[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

2017-04-13 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. I think it would be better to move this logic to the driver and have it pass in an `-mllvm` flag. The sanitizer passes should really be taking no arguments in the constructor like the other passes, so I don't want us to add another argument here. Repository: rL LLVM ht

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

2017-04-13 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis added a comment. From a quick look at the code, it seems like -fno-data-sections on COFF would suppress GC of globals the same as on ELF. Is that true? Repository: rL LLVM https://reviews.llvm.org/D32064 ___ cfe-commits mailing list cfe-

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

2017-04-13 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis created this revision. The linux part is a bit ahead of time - the instrumentation code where this matters have not landed yet. But when it does, this would be the right condition, and for now ELF instrumentation simply ignores this setting. Repository: rL LLVM https://reviews.llvm.