This revision was automatically updated to reflect the committed changes.
Closed by commit rL309548: Added `applyAtomicChanges` function. (authored by
ioeric).
Repository:
rL LLVM
https://reviews.llvm.org/D30777
Files:
cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h
cfe/trunk/l
ioeric updated this revision to Diff 108881.
ioeric added a comment.
- Merged with origin/master
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
lib/Tooling/Refactoring/CMakeLists.txt
unittests/Tooling/Refa
ioeric reopened this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
This (https://reviews.llvm.org/rL298913) was reverted upstream due to cyclic
dependency on GreenDragon bot. Investigating...
Repository:
rL LLVM
https://reviews.llvm.org/D30777
ioeric updated this revision to Diff 94497.
ioeric added a comment.
Herald added a subscriber: mgorny.
- Try to unbreak buildbots after r298913.
- Add clangFormat to dependency
- Update cmake
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling
Thank you Nakamura!
On Tue, Mar 28, 2017, 16:35 NAKAMURA Takumi via Phabricator <
revi...@reviews.llvm.org> wrote:
> chapuni added inline comments.
>
>
>
> Comment at: cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h:19
> #include "clang/Basic/SourceManager.h"
> +#incl
chapuni added inline comments.
Comment at: cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h:19
#include "clang/Basic/SourceManager.h"
+#include "clang/Format/Format.h"
#include "clang/Tooling/Core/Replacement.h"
It requires clangFormat in LINK_LIBS. F
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298913: Added `applyAtomicChanges` function. (authored by
ioeric).
Changed prior to commit:
https://reviews.llvm.org/D30777?vs=93231&id=93232#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30777
ioeric updated this revision to Diff 93231.
ioeric added a comment.
- addressed comment.
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/Refacto
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.. Very nice :)
Comment at: lib/Tooling/Refactoring/AtomicChange.cpp:102
+ Code.substr(StartPos, EndPos - StartPos).split(Lines, '\n');
+ for (llvm::StringRef L
ioeric added a comment.
Ping ;)
https://reviews.llvm.org/D30777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 91288.
ioeric marked 7 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/Refa
djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:139
+ // kNone: Don't format anything.
+ // kViolations: Format lines exceeding 80 columns.
+ enum FormatOption { kAll, kNone, kViolations };
Should probably be "exceed
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:147-149
+/// This completely ignores the file path in each change and replaces them with
+/// \p FilePath, i.e. callers are responsible for ensuring all changes are for
+/// the same file.
ioeric updated this revision to Diff 91163.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments; stylized code.
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tool
klimek added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:129
+struct ApplyChangesSpec {
+ // If true, cleans up redundant/erroneous around changed code with
+ // clang-format's cleanup functionality, e.g. redundant commas around deleted
---
ioeric created this revision.
... which applies a set of `AtomicChange`s on code.
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTes
16 matches
Mail list logo
