EricWF closed this revision.
EricWF added a comment.
Committed in r297355.
https://reviews.llvm.org/D30764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tomcherry added a comment.
I don't have commit access, so please commit for me.
Thank you
https://reviews.llvm.org/D30764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
@Tom Do you have commit acces or would you like me to commit this for you?
https://reviews.llvm.org/D30764
___
cfe-commits mailing list
cfe-commi
tomcherry updated this revision to Diff 9.
tomcherry added a comment.
Moved comments to an appropriate line
https://reviews.llvm.org/D30764
Files:
include/string
Index: include/string
===
--- include/string
+++ include/stri
EricWF added a comment.
Side note: There are plenty of tests in the test-suite that trigger this
overflow, so no new tests are needed.
When I have time I'm going to enable `-fsanitize=unsigned-integer-overflow`
once I have time to clean up any existing failures.
https://reviews.llvm.org/D3076
EricWF added inline comments.
Comment at: include/string:2559
// replace
+// __sz += __n2 - __n1; in the two functions below can cause unsigned integer
overflow,
+// but this is a safe operation, so we disable the check.
Please put this comment inside one of th
srhines added a comment.
You probably want to remove the Change-Id section above in your description (or
at least drop that when you finally submit this to libc++).
https://reviews.llvm.org/D30764
___
cfe-commits mailing list
cfe-commits@lists.llvm
