bkramer updated this revision to Diff 88352.
bkramer added a comment.
- Simplify code by not worrying about \r
- Don't allow blank lines between NOLINTNEXTLINE and the warning
https://reviews.llvm.org/D29899
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
test/clang-tidy/nolintnextline.cp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295049: [clang-tidy] Add support for NOLINTNEXTLINE.
(authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D29899?vs=88352&id=88353#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome! LG with one nit.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:300
+ // Now skip any newlines.
+ // FIXME: We want to skip over exactly one line, not an a
bkramer created this revision.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D29899
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
test/clang-tidy/nolintnextline.cpp
Index: test/clang-tidy/nolintnextline.cpp
