This revision was automatically updated to reflect the committed changes.
Closed by commit rL295335: [OpenMP] Teams reduction on the NVPTX device.
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29879?vs=88715&id=88746#toc
Repository:
rL LLVM
https://reviews.llvm.or
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arpith-jacob updated this revision to Diff 88715.
arpith-jacob added a comment.
Addressed review comments.
https://reviews.llvm.org/D29879
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/nvptx_teams_reduction_codegen.cpp
Index: test/OpenMP/nvptx_teams
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:715
+// lane_offset, int16_t shortCircuit),
+// void (*kmp_InterWarpCopyFctPtr)(void* src, int warp_num),
+// void (*kmp_CopyToScratchpadFctPtr)(void *reduce_data, void * scratchpad,
-
arpith-jacob marked an inline comment as done.
arpith-jacob added a comment.
Alexey, do you any more comments on this patch?
https://reviews.llvm.org/D29879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
arpith-jacob marked 8 inline comments as done.
arpith-jacob added a comment.
Alexey, thank you for your review. I have used SizeTy instead of assuming
64-bits.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:725
+/*isVarArg=*/false);
+llvm
arpith-jacob updated this revision to Diff 88407.
arpith-jacob added a comment.
Use SizeTy instead of assuming 64 bits!
https://reviews.llvm.org/D29879
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/nvptx_teams_reduction_codegen.cpp
Index: test/OpenM
ABataev added a comment.
General note:
Be more strict with the types. For indeces it's better to use `SizeTy` or
`UintPtrTy`, if `Int32Ty` is specified as type of parameter, use `Int32y`, not
`IntTy`
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:725
+
arpith-jacob created this revision.
Herald added a subscriber: jholewinski.
This patch implements codegen for the reduction clause on
any teams construct for elementary data types. It builds
on parallel reductions on the GPU. Subsequently,
the team master writes to a unique location in a global
