[PATCH] D29827: [AVR] Add -mmcu option to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL300818: [AVR] Add -mmcu option to the driver (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D29827?vs=95707&id=95879#toc Repository: rL LLVM https://reviews.llvm.org/D298

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai accepted this revision. xiangzhai added a comment. This revision is now accepted and ready to land. Hi Peter, Thanks for your rebase! LGTM! > Based on the context, the change from lib/Driver/Tools.cpp -> > lib/Driver/ToolChains/CommonArgs.cpp seems most appropriate (Gnu.cpp seems to

[PATCH] D29827: [AVR] Add -mmcu option to the driver

Lekensteyn updated this revision to Diff 95707. Lekensteyn added a comment. v2: rebase on commit ad25f8b712f1ef99020fcb7b5e31dd95b39c6112 (trunk@300661) Based on the context, the change from lib/Driver/Tools.cpp -> lib/Driver/ToolChains/CommonArgs.cpp seems most appropriate (Gnu.cpp seems to be

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai added a comment. Hi Jonathan, Peter might do not have commit access, please commit it on his behalf, thanks a lot! Regards, Leslie Zhai https://reviews.llvm.org/D29827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D29827: [AVR] Add -mmcu option to the driver

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Driver/Options.td:1613 def mcpu_EQ : Joined<["-"], "mcpu=">, Group; +def mmcu_EQ : Joined<["-"], "mmcu=">, Group; def mdynamic_no_pic : J

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai added a comment. ping :) https://reviews.llvm.org/D29827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29827: [AVR] Add -mmcu option to the driver

Lekensteyn added inline comments. Comment at: include/clang/Driver/Options.td:1613 def mcpu_EQ : Joined<["-"], "mcpu=">, Group; +def mmcu_EQ : Joined<["-"], "mmcu=">, Group; def mdynamic_no_pic : Joined<["-"], "mdynamic-no-pic">, Group; dylanmckay wrote: > Leke

[PATCH] D29827: [AVR] Add -mmcu option to the driver

dylanmckay added inline comments. Comment at: include/clang/Driver/Options.td:1613 def mcpu_EQ : Joined<["-"], "mcpu=">, Group; +def mmcu_EQ : Joined<["-"], "mmcu=">, Group; def mdynamic_no_pic : Joined<["-"], "mdynamic-no-pic">, Group; Lekensteyn wrote: > jroe

[PATCH] D29827: [AVR] Add -mmcu option to the driver

Lekensteyn added inline comments. Comment at: include/clang/Driver/Options.td:1613 def mcpu_EQ : Joined<["-"], "mcpu=">, Group; +def mmcu_EQ : Joined<["-"], "mmcu=">, Group; def mdynamic_no_pic : Joined<["-"], "mdynamic-no-pic">, Group; jroelofs wrote: > Would

[PATCH] D29827: [AVR] Add -mmcu option to the driver

jroelofs added inline comments. Comment at: include/clang/Driver/Options.td:1613 def mcpu_EQ : Joined<["-"], "mcpu=">, Group; +def mmcu_EQ : Joined<["-"], "mmcu=">, Group; def mdynamic_no_pic : Joined<["-"], "mdynamic-no-pic">, Group; Would it make sense to hav

[PATCH] D29827: [AVR] Add -mmcu option to the driver

Lekensteyn created this revision. Add the AVR-specific -mmcu option for compatibility with GCC (GCC does not use -mcpu nor -march for AVR). This option is needed to inform the frontend to define some macros (for example) and the inform the assembler of the allowed features, so add a test to check