djasper marked an inline comment as done.
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:178
- LastBlockComment = &Change;
-} else if (Change.Kind == tok::unknown) {
- if ((Change.StartOfBlockComment = LastBlockComment))
krasimir added a comment.
looks good!
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:178
- LastBlockComment = &Change;
-} else if (Change.Kind == tok::unknown) {
- if ((Change.StartOfBlockComment = LastBlockComment))
What happened to the tok::unknown case?
djasper closed this revision.
djasper added a comment.
Submitted as r293616.
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper updated this revision to Diff 86404.
djasper added a comment.
Added assert. Removed unused InToken.
https://reviews.llvm.org/D29300
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
djasper marked an inline comment as done.
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:904-907
+void UnwrappedLineFormatter::formatFirstToken(const AnnotatedLine &Line,
const AnnotatedLine
*Previo
klimek added a comment.
Generally looks like the right direction, minus that I'm not sure yet what the
plan for things broken in BreakableToken are.
Comment at: lib/Format/TokenAnnotator.cpp:1843
+Current->MatchingParen->opensBlockOrBlockTypeList(Style))
+ --Inden
djasper created this revision.
The main motivation behind this is to cleanup the WhitespaceManager and make it
more extensible for future alignment etc. features. Specifically,
WhitespaceManager has started to copy more and more code that is already
present in FormatToken. Instead, I think it m
