Re: [PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-20 Thread Richard Smith via cfe-commits
On 20 January 2017 at 11:53, Eric Fiselier via Phabricator < revi...@reviews.llvm.org> wrote: > EricWF added a comment. > > @rsmith I looked for an alternative provider for aligned allocation but > couldn't find one, which is quite unfortunate. Is this going to mess up the > `__libcpp_version` det

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-20 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. @rsmith I looked for an alternative provider for aligned allocation but couldn't find one, which is quite unfortunate. Is this going to mess up the `__libcpp_version` detection Clang does? https://reviews.llvm.org/D28931 __

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Greg Parker via Phabricator via cfe-commits
gparker42 added a comment. No, the old versions of OS X that lack `posix_memalign` also lack `aligned_alloc`. https://reviews.llvm.org/D28931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. Does OS X have the C11 `aligned_alloc` function? Perhaps we could use that instead, when available. https://reviews.llvm.org/D28931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D28931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 85082. EricWF added a comment. - Move `__config` block lower down in the file as suggested by Marshall. https://reviews.llvm.org/D28931 Files: include/__config include/new src/new.cpp Index: src/new.cpp ===

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 85080. EricWF added a comment. - Remove `` include in place of defining the required macros manually. https://reviews.llvm.org/D28931 Files: include/__config include/new src/new.cpp Index: src/new.cpp

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 85072. EricWF added a comment. - Remove NFC parts of this patch and commit them to master. https://reviews.llvm.org/D28931 Files: include/__config include/new src/new.cpp Index: src/new.cpp

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. This patch disables the aligned new/delet overloads on Apple platforms without `posix_memalign`. This fixes libc++.dylib build regressions on such platforms. This fixes http://llvm.org/PR31448. This patch should also be merged into the 4.0 release branch https://r