This revision was automatically updated to reflect the committed changes.
Closed by commit rL292562: clang-format: fix fallback style set to "none" not
always formatting (authored by amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D28844?vs=84795&id=85074#toc
Repository:
rL LLV
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/Format.cpp:1906
- // FIXME: If FallbackStyle is explicitly "none", format is disabled.
- if (!getPredefinedStyle(FallbackStyle, Style.Languag
amaiorano added inline comments.
Comment at: lib/Format/Format.cpp:1906
- // FIXME: If FallbackStyle is explicitly "none", format is disabled.
- if (!getPredefinedStyle(FallbackStyle, Style.Language, &Style))
-return make_string_error("Invalid fallback style \"" +
Fallba
amaiorano created this revision.
This change fixes the fact that fallback style set to "none" should not format.
Without this change, fallback style "none" ends up applying LLVM formatting.
https://reviews.llvm.org/D28844
Files:
lib/Format/Format.cpp
test/Format/style-on-command-line.cpp
