Prazek added a comment.
Ok, I didn't know that it is this easy to run alpha checks from clang.
https://reviews.llvm.org/D28729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In https://reviews.llvm.org/D28729#647250, @Prazek wrote:
> Does solution like this works for you? We don't officially support alpha
> checkers, but it is much easier to check if something is already implemented
> in static analyzer easily
Is it the only problem you're
Prazek added a comment.
Does solution like this works for you? We don't officially support alpha
checkers, but it is much easier to check if something is already implemented in
static analyzer easily
https://reviews.llvm.org/D28729
___
cfe-commits
Prazek updated this revision to Diff 84550.
Prazek marked an inline comment as done.
Prazek added a comment.
-enable-alpha-checks is now not visible for users, but it make
my life as clang-tidy developer much easier.
https://reviews.llvm.org/D28729
Files:
clang-tidy/ClangTidy.cpp
clang-tid
aaron.ballman added a comment.
In https://reviews.llvm.org/D28729#646876, @Prazek wrote:
> In https://reviews.llvm.org/D28729#646758, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D28729#646560, @alexfh wrote:
> >
> > > In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
>
Prazek added a comment.
In https://reviews.llvm.org/D28729#646758, @aaron.ballman wrote:
> In https://reviews.llvm.org/D28729#646560, @alexfh wrote:
>
> > In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
> > >
> >
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
In https://reviews.llvm.org/D28729#646560, @alexfh wrote:
> In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
> >
> > > As discussed with
Prazek added a comment.
So the problem I got is that every time I want to check if there is already a
feature in clang-tidy/static-analyzer that solves my issue, I either have to
deal with static-analyzer command line, which is horrible, or I have to modify
and recompile the source code.
The c
alexfh added a comment.
In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
> In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
>
> > As discussed with the Static Analyzer maintainers, alpha checkers are
> > completely unsupported and are suitable for very early testing only
aaron.ballman added a comment.
In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
> As discussed with the Static Analyzer maintainers, alpha checkers are
> completely unsupported and are suitable for very early testing only. We had
> problems with them routinely, that's why I disabled al
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:296
const auto &RegisteredCheckers =
- AnalyzerOptions::getRegisteredCheckers(/*IncludeExperimental=*/false);
bool AnalyzerChecksEnabled = false;
This is the place where a small local c
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
As discussed with the Static Analyzer maintainers, alpha checkers are
completely unsupported and are suitable for very early testing only. We had
problems with them routinely, that's
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few minor nits, but in the future, please provide some summary of
what your patch is going to do rather than leave it en
Prazek updated this revision to Diff 84448.
Prazek added a comment.
reformat
https://reviews.llvm.org/D28729
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/enable-alpha-checks.cpp
Index:
Prazek created this revision.
Prazek added a reviewer: alexfh.
Prazek added a subscriber: cfe-commits.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D28729
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/Cla
15 matches
Mail list logo
