[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D28588#644637, @danielcdh wrote: > Looks like this is still breaking these buildbots: > > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3216/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Athinlto_backend.ll > > I reverted th

Re: [PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Dehao Chen via cfe-commits
On Thu, Jan 12, 2017 at 3:27 PM, Teresa Johnson via Phabricator < revi...@reviews.llvm.org> wrote: > tejohnson added a comment. > > In https://reviews.llvm.org/D28588#644489, @danielcdh wrote: > > > Thanks for the prompt response. > > > > But looks like several other tests also has "-mllvm > -debu

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh added a comment. Looks like this is still breaking these buildbots: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3216/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Athinlto_backend.ll I reverted the test change for now, and am thinking of how to reproduce/fix the pr

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh updated this revision to Diff 84193. danielcdh added a comment. Updates the unittests to clang_cc1 to see if it fixes the buildbot failure. https://reviews.llvm.org/D28588 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/thinlto_backend.ll Index: test/CodeGen/thinlto_backend.ll =

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D28588#644489, @danielcdh wrote: > Thanks for the prompt response. > > But looks like several other tests also has "-mllvm -debug-pass=Structure" in > their tests: > > tools/clang/test/CodeGen/pgo-instrumentation.c > test/CodeGen/Generic/ll

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh added a comment. Thanks for the prompt response. But looks like several other tests also has "-mllvm -debug-pass=Structure" in their tests: tools/clang/test/CodeGen/pgo-instrumentation.c test/CodeGen/Generic/llc-start-stop.ll I just verified that if I cmake with -DCMAKE_BUILD_TYPE=Re

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D28588#644472, @tejohnson wrote: > Otherwise I think "; REQUIRES: asserts" might do the trick? Looks like it - I looked at another test that used -debug output and it requires asserts. https://reviews.llvm.org/D28588 _

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D28588#644467, @danielcdh wrote: > The breaks some buildbots thus I reverted the patch: > > http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1889 > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_ch

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-12 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh reopened this revision. danielcdh added a comment. This revision is now accepted and ready to land. The breaks some buildbots thus I reverted the patch: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1889 http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incr

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-11 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-11 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh created this revision. danielcdh added reviewers: tejohnson, mehdi_amini. danielcdh added a subscriber: cfe-commits. LTO backend will not invoke SampleProfileLoader pass even if -fprofile-sample-use is specified. This patch passes the flag down so that pass manager can add the SamplePr