[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-07 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd abandoned this revision. compnerd added a comment. We have a temporary workaround while a proper macro is considered by SD-6. Repository: rL LLVM https://reviews.llvm.org/D28383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-06 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D28383#637672, @compnerd wrote: > @rnk happy to add such a macro. Would `__cpp_abi_itanium` and > `__cpp_abi_microsoft` be palatable? I would love these macros. I would prefer if the stock `__config` worked for all but the rarest of configu

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. @rnk happy to add such a macro. Would `__cpp_abi_itanium` and `__cpp_abi_microsoft` be palatable? This actually does get encoded into `__config` albeit in a round-about way. The `__config_site` gets concatenated with `__config` into `__generated_config` which is ins

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D28383#637570, @majnemer wrote: > Why isn't this equivalent to `_MSC_VER` ? It might also be nice for clang to define some macro to indicate which C++ ABI is in use. All that said, I think it makes sense to encode this in libc++ include/__conf

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D28383#637570, @majnemer wrote: > Why isn't this equivalent to `_MSC_VER` ? You can have scenarios where you're targeting the Itanium ABI but still have `_MSC_VER` defined, e.g. % clang -target i686-windows-itanium -fmsc-version=1900 -E -

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. Why isn't this equivalent to `_MSC_VER` ? Repository: rL LLVM https://reviews.llvm.org/D28383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists, smeenai, kastiglione. compnerd added subscribers: cfe-commits, rnk. compnerd set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. We need to have a more principled method to detect the C++