This revision was automatically updated to reflect the committed changes.
Closed by commit rL291303: [ThinLTO] Optionally ignore empty index file
(authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D28362?vs=83405&id=83450#toc
Repository:
rL LLVM
https://reviews.llvm.
tejohnson added a comment.
In https://reviews.llvm.org/D28362#638260, @mehdi_amini wrote:
> > In order to simplify distributed build system integration, where actions
> > may be scheduled before the Thin Link which determines the list of
> > objects selected by the linker. The gold plugin curre
mehdi_amini added a comment.
> In order to simplify distributed build system integration, where actions
may be scheduled before the Thin Link which determines the list of
objects selected by the linker. The gold plugin currently will emit
0-sized index files for objects not selected by the link,
tejohnson added a comment.
In https://reviews.llvm.org/D28362#638203, @mehdi_amini wrote:
> LGTM
Thanks, let me know if the llvm companion patch
(https://reviews.llvm.org/D28410) is ok as well.
https://reviews.llvm.org/D28362
___
cfe-commits mai
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D28362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tejohnson updated this revision to Diff 83405.
tejohnson added a comment.
Move option to LLVM.
https://reviews.llvm.org/D28362
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/thinlto_backend.ll
Index: test/CodeGen/thinlto_backend.ll
tejohnson added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:65
+"Ignore an empty index file and perform non-ThinLTO compilation"),
+llvm::cl::init(false));
+
tejohnson wrote:
> mehdi_amini wrote:
> > Is it common to do this in clang?
> Do
tejohnson added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:65
+"Ignore an empty index file and perform non-ThinLTO compilation"),
+llvm::cl::init(false));
+
mehdi_amini wrote:
> Is it common to do this in clang?
Doesn't look common, but
mehdi_amini added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:65
+"Ignore an empty index file and perform non-ThinLTO compilation"),
+llvm::cl::init(false));
+
Is it common to do this in clang?
https://reviews.llvm.org/D28362
___
tejohnson created this revision.
tejohnson added a reviewer: mehdi_amini.
tejohnson added a subscriber: cfe-commits.
In order to simplify distributed build system integration, where actions
may be scheduled before the Thin Link which determines the list of
objects selected by the linker. The gold
10 matches
Mail list logo
