This revision was automatically updated to reflect the committed changes.
Closed by commit rL290891: [clang-move] Support moving enum declarations.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D28228?vs=82876&id=82879#toc
Repository:
rL LLVM
https://reviews.llvm.o
hokein updated this revision to Diff 82876.
hokein marked an inline comment as done.
hokein added a comment.
Not change in ClangMove.h
https://reviews.llvm.org/D28228
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/enum.h
test/clang-move/move-enum-decl.cpp
unittests/clang-move/Cl
hokein updated this revision to Diff 82875.
hokein added a comment.
Remove forgot-deleted code.
https://reviews.llvm.org/D28228
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/enum.h
test/clang-move/move-enum-decl.cpp
unittests/clang-move/ClangMoveTests.c
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:456
+void ClangMoveTool::addMovedAndDeletedDecl(const NamedDecl *D) {
+ MovedDecls.push_back(D);
Remove this?
ht
hokein added a comment.
In https://reviews.llvm.org/D28228#633930, @ioeric wrote:
> I mean, if a enum helper used in say only old cc, will it be moved? The
> question is related to https://reviews.llvm.org/D27673. You don't need to
> support enum helper now, but it would be nice to drop a comme
hokein updated this revision to Diff 82874.
hokein marked an inline comment as done.
hokein added a comment.
Refine function name and add a comment for enum helpers.
https://reviews.llvm.org/D28228
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/enum.h
test
ioeric added a comment.
In https://reviews.llvm.org/D28228#633925, @hokein wrote:
> In https://reviews.llvm.org/D28228#633863, @ioeric wrote:
>
> > Do we consider enum helpers?
>
>
> This patch excludes enum helpers, only considers the enum declarations which
> are defined in old.h.
> Ideally,
hokein updated this revision to Diff 82872.
hokein marked an inline comment as done.
hokein added a comment.
Address review comment.
https://reviews.llvm.org/D28228
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/enum.h
test/clang-move/move-enum-decl.cpp
hokein added a comment.
In https://reviews.llvm.org/D28228#633863, @ioeric wrote:
> Do we consider enum helpers?
This patch excludes enum helpers, only considers the enum declarations which
are defined in old.h.
Ideally, we should support enum helpers which are defined in old.cc, but that's
ioeric added a comment.
Do we consider enum helpers?
Comment at: clang-move/ClangMove.cpp:171
+assert(ED);
+MoveTool->getMovedDecls().push_back(ED);
+MoveTool->getUnremovedDeclsInOldHeader().erase(ED);
These 3 lines seen to be repeated. Maybe pull t
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D28228
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/enum.h
test/clang-move/move-enum-decl.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests
11 matches
Mail list logo
