alexshap added inline comments.
Comment at: lib/Basic/SourceManager.cpp:843
if (E.getOffset() <= SLocOffset) {
FileID Res = FileID::get(-int(I) - 2);
not particularly important (and unrelated to your changes) - nit - s /C-style
cast / static_cast /
bruno added a comment.
Hi Daniel,
This seems pretty nice. Can you share how much performance improvements you got
by this / how did you test it?
https://reviews.llvm.org/D28218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
djasper added a comment.
Ping?
https://reviews.llvm.org/D28218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper created this revision.
djasper added a reviewer: rsmith.
djasper added a subscriber: cfe-commits.
Specifically:
- Separate one-entry cache for loaded and local files
- Use bound that can be deduced from that cache for LessIndex
- Address FIXME to use a faster alternative to isOffsetInFile
