This revision was automatically updated to reflect the committed changes.
Closed by commit rL290904: [OpenMP] Code cleanup for NVPTX OpenMP codegen
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D28124?vs=82619&id=82931#toc
Repository:
rL LLVM
https://reviews.llvm.o
ABataev added a comment.
LG
https://reviews.llvm.org/D28124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arpith-jacob updated this revision to Diff 82619.
arpith-jacob added a comment.
Addressed comments in review to start function names with a lowercase letter
and to fix the enum type name along with the enumerator name.
https://reviews.llvm.org/D28124
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.c
jlebar added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:31
+// NVPTX Address space
+enum ADDRESS_SPACE {
+ ADDRESS_SPACE_SHARED = 3,
Please fix enum typename name and the name of the enumerator:
http://llvm.org/docs/CodingStandards.html#n
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
Function names must start with a lower case letter. LG for other changes
https://reviews.llvm.org/D28124
___
cfe-commits mailing list
cfe-commi
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0, caomhin.
arpith-jacob added a subscriber: cfe-commits.
Herald added a subscriber: jholewinski.
This patch cleans up private methods for NVPTX OpenMP codegen. It converts
private members to
