This revision was automatically updated to reflect the committed changes.
Closed by commit rL292659: [Altivec] Change vec_sl to a << (b % (sizeof(a) *
8)) (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D28037?vs=83140&id=85194#toc
Repository:
rL LLVM
https://review
timshen added a comment.
In https://reviews.llvm.org/D28037#652021, @echristo wrote:
> Going to commit this?
I'd like to commit https://reviews.llvm.org/D28329 first. If we commit this
now, the normal code will be slower.
https://reviews.llvm.org/D28037
___
Please go ahead and commit, we'll worry about speed after correctness.
-eric
On Fri, Jan 20, 2017 at 2:10 PM Tim Shen via Phabricator <
revi...@reviews.llvm.org> wrote:
> timshen added a comment.
>
> In https://reviews.llvm.org/D28037#652021, @echristo wrote:
>
> > Going to commit this?
>
>
> I'
echristo added a comment.
Going to commit this?
https://reviews.llvm.org/D28037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
LGTM.
Thanks!
-eric
https://reviews.llvm.org/D28037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen updated this revision to Diff 83140.
timshen added a comment.
Update comments, and move llvm changes to another patch.
https://reviews.llvm.org/D28037
Files:
clang/lib/Headers/altivec.h
clang/test/CodeGen/builtins-ppc-altivec.c
Index: clang/test/CodeGen/builtins-ppc-altivec.c
=
