a.sidorin added a comment.
Hello Kareem,
While the functionality of this patch is already implemented in my already
merged patch, I added your tests into the repo. Thank you!
https://reviews.llvm.org/D27181
___
cfe-commits mailing list
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319632: [ASTImporter] Add unit tests for UsingDecl and
UsingShadowDecl (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D27181?vs=79488&id=125290#toc
Repository:
rL LLVM
ht
a.sidorin added inline comments.
Comment at: lib/AST/ASTImporter.cpp:4305
+ DeclarationNameInfo NameInfo(Name,
Importer.Import(D->getNameInfo().getLoc()));
+ ImportDeclarationNameLoc(D->getNameInfo(), NameInfo);
+
spyffe wrote:
> I've seen this pattern before,
spyffe added a comment.
Looks good, but I have a concern about the underlying branch's apparently
inconsistent initialization of `DeclarationNameInfo`. Aleksei, could you
clarify how that code works? Should we have a helper function so we don't have
to carefully repeat this pattern everywhere
a.sidorin added a comment.
Thank you Kareem, It looks mostly good, but I'd like to have some functional
tests in ASTMerge for this patch.
Comment at: lib/AST/ASTImporter.cpp:4299
+ if (ImportDeclParts(D, DC, LexicalDC, Name, AlreadyImported, Loc))
+return NULL;
+ assert(
klimek added a comment.
Can you add a test to ASTMatchersNodeTests.cpp? Otherwise LG for the matcher
parts.
https://reviews.llvm.org/D27181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
khazem created this revision.
khazem added reviewers: spyffe, a.sidorin.
khazem added subscribers: cfe-commits, phosek, seanklein, klimek.
Some of this patch comes from Aleksei's branch [1], with minor revisions. I've
added unit tests and AST Matcher support. Copying in Manuel in case there is no
